executor: remove direct reference to loopback - #15
Merged
Conversation
Modify the executor to access the loopback object via `app.loopback`.
Fall back to `require('loopback')` only when `app.loopback` is not set
(loopback versions before 1.9).
bajtos
referenced
this pull request
in strongloop/loopback
Jun 25, 2014
Modify `app.boot` to throw an exception, pointing users to the new module `loopback-boot`.
Member
|
LGTM |
bajtos
added a commit
that referenced
this pull request
Jun 26, 2014
…opback executor: remove direct reference to loopback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the executor to access the loopback object via
app.loopback.Fall back to
require('loopback')only whenapp.loopbackis not set(loopback versions before 1.9).
This change makes it possible to use loopback-boot inside loopback unit-tests among other things.
/to @ritch please review.